alamb commented on code in PR #5132:
URL: https://github.com/apache/arrow-datafusion/pull/5132#discussion_r1103118269
##########
datafusion/expr/src/logical_plan/builder.rs:
##########
@@ -403,6 +403,28 @@ impl LogicalPlanBuilder {
Ok(())
})?;
+ // if current plan is distinct or current plan is repartition and its
child plan is distinct,
+ // then this plan is a select distinct plan
+ let is_select_distinct = match self.plan {
+ LogicalPlan::Distinct(_) => true,
+ LogicalPlan::Repartition(Repartition { ref input, .. }) => {
+ matches!(input.as_ref(), &LogicalPlan::Distinct(_))
+ }
+ _ => false,
Review Comment:
So in my opinion this PR is better than the code on master, though I think
it could be improved with the suggestions from @liukun4515 and @jackwener
@xiaoyong-z please let us know what you want to do -- we can merge and
improve in a follow on or we can implement the suggestions in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
