alamb commented on code in PR #5253:
URL: https://github.com/apache/arrow-datafusion/pull/5253#discussion_r1103630519
##########
datafusion/core/tests/sqllogictests/README.md:
##########
@@ -105,10 +105,13 @@ query <type_string> <sort_mode>
- `test_name`: Uniquely identify the test name (arrow-datafusion only)
- `type_string`: A short string that specifies the number of result columns
and the expected datatype of each result column. There is one character in the
<type_string> for each result column. The characters codes are:
- - "T" for a text result,
- - "I" for an integer result,
- - "R" for a floating-point result,
- - "?" for any other type.
+ - 'B' - **B**oolean,
+ - 'D' - **D**atetime,
+ - 'I' - **I**nteger,
+ - 'F' - **F**loating-point results,
+ - 'S' - **S**string,
+ - 'T' - **T**imestamp,
+ - "?" - any other types
Review Comment:
I think we should stick as close as possibly to other standards -- so
therefore I suggest:
`T` for text
`P` for timestamP
I also think it would be good to differentiate between `F` and `R` if
possible
What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
