comphead commented on PR #5246: URL: https://github.com/apache/arrow-datafusion/pull/5246#issuecomment-1426829245
> > I, unfortunately, cannot tell if this check is always needed. It was added in https://github.com/apache/arrow-datafusion/pull/4578/files#diff-4d4a58673140be1acf7a04b9aa71a29f106ebb75a256553e2a9ff13d9a3856f4. @alamb Could you please take a look. > > We have seen this in the past where schemas differ only in nullability (hence `equivalent_names_and_types`) > > It might be safer to change the check to verify the fields name and types (rather than `schema == schema`). What do you think @comphead and @melgenek ? I'm still thinking the check is redundant, as batches within one query execution shouldn't have difference in types and fields. But to be safe I'll add the type/fields check today -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
