kou commented on PR #34152: URL: https://github.com/apache/arrow/pull/34152#issuecomment-1427130198
Thanks for the patch! But they are needless. There are 2 `FindProtobuf.cmake`s, `FindProtobuf.cmake` in CMake itself ( https://gitlab.kitware.com/cmake/cmake/-/blob/master/Modules/FindProtobuf.cmake ) and `FindProtobuf.cmake` in Apache ORC ( https://github.com/apache/orc/blob/main/cmake_modules/FindProtobuf.cmake ). The former uses `Protobuf_PROTOC_EXECUTABLE` and the latter uses `PROTOBUF_PROTOC_EXECUTABLE`. And we already use `PROTOBUF_PROTOC_EXECUTABLE` for Apache ORC: https://github.com/apache/arrow/blob/master/cpp/cmake_modules/ThirdpartyToolchain.cmake#L4443 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
