alamb commented on code in PR #5261:
URL: https://github.com/apache/arrow-datafusion/pull/5261#discussion_r1104379473


##########
datafusion/optimizer/src/push_down_projection.rs:
##########
@@ -523,13 +523,24 @@ fn push_down_scan(
         }
     }
 
+    // Building new projection from BTreeSet
+    // preserving source projection order if it exists
+    let projection = if let Some(original_projection) = &scan.projection {
+        original_projection

Review Comment:
   What about columns that are in `projection` but not in `original_projection` 
(as in the original projection did not contain sufficient columns for the 
query)?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to