Ted-Jiang opened a new issue, #3708:
URL: https://github.com/apache/arrow-rs/issues/3708

   **Is your feature request related to a problem or challenge? Please describe 
what you are trying to do.**
   
https://github.com/apache/arrow-datafusion/commit/48732b4cb2c8e42fbe5be295429bbc465e5f5491
  all math compute kernel like add_dyn_scalar, multi_dyn_scalar...
   I try to use use copy one write (mock func add_scalar_mut use 
https://github.com/apache/arrow-rs/blob/26ea71cefab55990ffb8197707f2a8518e41412d/arrow-arith/src/arity.rs#L59)
   run `select t.a + 1 from t`
   got
   ```
   warning: `datafusion` (bench "math_query_sql") generated 1 warning
       Finished bench [optimized] target(s) in 7m 26s
        Running benches/math_query_sql.rs 
(target/release/deps/math_query_sql-64399df00616f72b)
   Benchmarking tess_add: Warming up for 3.0000 s
   Warning: Unable to complete 100 samples in 5.0s. You may wish to increase 
target time to 6.4s, enable flat sampling, or reduce sample count to 60.
   tess_add                time:   [1.2643 ms 1.2664 ms 1.2685 ms]
                           change: [-78.711% -78.544% -78.361%] (p = 0.00 < 
0.05)
                           Performance has improved.
   Found 5 outliers among 100 measurements (5.00%)
     2 (2.00%) low severe
     1 (1.00%) high mild
     2 (2.00%) high severe
   
   (venv) yangjiang@LM-SHC-15009782 arrow-datafusion %
   ```
   
   **Describe the solution you'd like**
   <!--
   A clear and concise description of what you want to happen.
   -->
   Add `unary_dyn_mut` which take ownership of array then support cow math 
operator.
   
   **Describe alternatives you've considered**
   <!--
   A clear and concise description of any alternative solutions or features 
you've considered.
   -->
   
   **Additional context**
   <!--
   Add any other context or screenshots about the feature request here.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to