zeroshade commented on code in PR #34167:
URL: https://github.com/apache/arrow/pull/34167#discussion_r1105183460
##########
.github/workflows/go.yml:
##########
@@ -369,3 +369,40 @@ jobs:
- name: Test
shell: bash
run: ci/scripts/go_test.sh $(pwd)
+
+ noasm:
+ name: AMD64 Debian 11 Go ${{ matrix.go }} - NOASM
+ runs-on: ubuntu-latest
+ if: ${{ !contains(github.event.pull_request.title, 'WIP') }}
+ timeout-minutes: 60
+ strategy:
+ fail-fast: false
+ matrix:
+ go: [1.17, 1.18]
+ include:
+ - go: 1.17
+ staticcheck: v0.2.2
+ - go: 1.18
+ staticcheck: v0.3.3
+ env:
+ GO: ${{ matrix.go }}
+ STATICCHECK: ${{ matrix.staticcheck }}
+ steps:
+ - name: Checkout Arrow
+ uses: actions/checkout@v3
+ with:
+ fetch-depth: 0
+ submodules: recursive
+ - name: Install go
+ uses: actions/setup-go@v3
+ with:
+ go-version: ${{ matrix.go }}
+ cache: true
+ cache-dependency-path: go/go.sum
+ - name: Install staticcheck
Review Comment:
@lidavidm we call staticcheck in the `go_test.sh` file so that's why I did
it here, though technically we don't necessarily need it in all the pipelines
but we should have it run in the both `asm` and `noasm` pipelines since it
changes which files actually get included.
that said, I can definitely shoehorn this into one of the existing jobs
instead as @assignUser requested :smile: I'll update this tomorrow to avoid
making another job
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
