wjones127 commented on code in PR #428: URL: https://github.com/apache/arrow-adbc/pull/428#discussion_r1105183630
########## adbc.h: ########## @@ -1183,7 +1204,11 @@ AdbcStatusCode AdbcStatementExecutePartitions(struct AdbcStatement* statement, /// driver. /// /// Although drivers may choose any name for this function, the -/// recommended name is "AdbcDriverInit". +/// recommended name is "AdbcDriverInit". If you use the recommended +/// name, then driver managers will be able to automatically find +/// the entrypoint function. Drivers may also expose the same function +/// under a unique symbol so that multiple drivers can be statically +/// linked into a single binary without any conflicts. Review Comment: FWIW I think the Rust implementation I've written isn't that far off here. With a little work we can probably transform this file into the "Rust ADBC API" https://github.com/wjones127/arrow-adbc/blob/rust-driver-manager/rust/src/interface.rs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
