nevi-me commented on pull request #8665: URL: https://github.com/apache/arrow/pull/8665#issuecomment-727578474
Reran the tests, failure now confirmed: https://github.com/nevi-me/arrow/runs/1402675504#step:8:2084 The C++ implementation has avx512 support, so maybe @kszucs or someone else deeply familiar with our CI knows what a probable solution is. Otherwise this might be a matter for the mailing list. My position is that I'm happy to still proceed with merging this, because this doesn't break CI for stable and nightly. Else, we could open a separate branch where we can merge this into, to avoid @vertexclique having to pile up PRs on top of each other. It gets very irritating after a while, from my experience with the parquet writer. This separate branch could also temporarily house ARMv7, as we don't yet have CI for it. ___ @jorgecarleitao what's your opinion on us testing `arrow` separately on stable, to ensure that we don't regress? Something like: ```sh # run unit tests, excluding arrow cargo test --exclude arrow # run unit tests on arrow separately pushd arrow # run arrow unit tests on stable cargo +stable test # run arrow unit tests with features, separate test for mutually exclusive oens cargo test --features "simd" cargo test --features "avx512" popd ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
