jorisvandenbossche commented on PR #33925: URL: https://github.com/apache/arrow/pull/33925#issuecomment-1429432072
Personally I am not sure what `strides` would provide that `dim_names` and/or `permutation` couldn't do, while being more difficult to work with and not being a full solution (it doesn't allow for names). So I would go for either just an optional `dim_names` (with the convention that if you don't have actual names for dimensions but would like to indicate a typical permutation, you can use integer names to do that), or optional `dim_names` + optional `permutation` (if we think that it is important to be able to specify both separately, or if it's cleaner to not mix integers in the dim_names). Both of those should cover the two use cases that Antoine mentioned above at https://github.com/apache/arrow/pull/33925#issuecomment-1422986313 (in the end, it's maybe mostly a choice between `strides` and `permutation`, as both hold the same information but in a different form, and we need `dim_names` anyway if we want to give the option to preserve dimension name information for applications that do natively have those) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
