mapleFU commented on code in PR #34177:
URL: https://github.com/apache/arrow/pull/34177#discussion_r1105958264
##########
cpp/src/parquet/encoding.cc:
##########
@@ -480,11 +480,18 @@ class DictEncoderImpl : public EncoderImpl, virtual
public DictEncoder<DType> {
public:
typedef typename DType::c_type T;
- explicit DictEncoderImpl(const ColumnDescriptor* desc, MemoryPool* pool)
- : EncoderImpl(desc, Encoding::PLAIN_DICTIONARY, pool),
+ explicit DictEncoderImpl(const ColumnDescriptor* desc, Encoding::type
dict_encoding,
Review Comment:
Right, currently they will be decided by `dictionary_index_page()` in
`WriterProperties`
And currently, there encoding logic are similiar
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
