alamb commented on code in PR #5241:
URL: https://github.com/apache/arrow-datafusion/pull/5241#discussion_r1106342898
##########
datafusion/core/src/physical_plan/aggregates/mod.rs:
##########
@@ -811,22 +811,22 @@ mod tests {
common::collect(partial_aggregate.execute(0,
task_ctx.clone())?).await?;
let expected = vec![
- "+---+---+-----------------+",
- "| a | b | COUNT(1)[count] |",
- "+---+---+-----------------+",
- "| | 1 | 2 |",
- "| | 2 | 2 |",
- "| | 3 | 2 |",
- "| | 4 | 2 |",
- "| 2 | | 2 |",
- "| 2 | 1 | 2 |",
- "| 3 | | 3 |",
- "| 3 | 2 | 2 |",
- "| 3 | 3 | 1 |",
- "| 4 | | 3 |",
- "| 4 | 3 | 1 |",
- "| 4 | 4 | 2 |",
- "+---+---+-----------------+",
+ "+---+-----+-----------------+",
+ "| a | b | COUNT(1)[count] |",
+ "+---+-----+-----------------+",
+ "| | 1.0 | 2 |",
Review Comment:
these changes are going to create some serious downstream churn I suspect. I
wonder if we should wait until https://github.com/apache/arrow-rs/pull/3717 is
released (so downstream crates can choose to have the old behavior) 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
