kou commented on code in PR #34159:
URL: https://github.com/apache/arrow/pull/34159#discussion_r1106406288
##########
java/gandiva/CMakeLists.txt:
##########
@@ -38,6 +38,7 @@ set(GANDIVA_PROTO_DIR ${CMAKE_CURRENT_SOURCE_DIR}/proto)
get_filename_component(GANDIVA_PROTO_FILE_ABSOLUTE
${GANDIVA_PROTO_DIR}/Types.proto
ABSOLUTE)
+set(Protobuf_USE_STATIC_LIBS ON)
Review Comment:
Could you specify this in build script (`ci/scripts/java_jni_build.sh`)?
Some users may want to use `libprotobuf.so`.
##########
java/gandiva/CMakeLists.txt:
##########
@@ -38,6 +38,7 @@ set(GANDIVA_PROTO_DIR ${CMAKE_CURRENT_SOURCE_DIR}/proto)
get_filename_component(GANDIVA_PROTO_FILE_ABSOLUTE
${GANDIVA_PROTO_DIR}/Types.proto
ABSOLUTE)
+set(Protobuf_USE_STATIC_LIBS ON)
find_package(Protobuf REQUIRED)
if(MSVC)
Review Comment:
It's not related to this pull request but could you remove this `if(MSVC)`?
It's not needed with recent CMake.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
