jorisvandenbossche commented on code in PR #33925: URL: https://github.com/apache/arrow/pull/33925#discussion_r1106920638
########## docs/source/format/CanonicalExtensions.rst: ########## @@ -72,4 +72,57 @@ same rules as laid out above, and provide backwards compatibility guarantees. Official List ============= -No canonical extension types have been standardized yet. +Fixed shape tensor +================== + +* Extension name: `arrow.fixed_shape_tensor`. + +* The storage type of the extension: ``FixedSizeList`` where: + + * **value_type** is the data type of individual tensors and + is an instance of ``pyarrow.DataType`` or ``pyarrow.Field``. + * **list_size** is the product of all the elements in tensor shape. + +* Extension type parameters: + + * **value_type** = Arrow DataType of the tensor elements + * **shape** = shape of the contained tensors as a tuple Review Comment: There is not a strict difference between both. The parameters are the information a user would need to provide to fully define an instance of this extension type (in in a C++ or Python API), and so the optional dim_names/permutation is part of that (even though they are not essential for the interpretation, hence they are optional). _Most_ of the parameters are then represented in the serizalization metadata (but `value_type` is not, because that parameter is already part of the physical storage type). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
