comphead commented on issue #5259: URL: https://github.com/apache/arrow-datafusion/issues/5259#issuecomment-1432306444
@ozankabak thanks for feedback, the discussion is already much broader than log function itself. You may want to create a separate topic to discuss failfast/failsafe approaches in detail. Moreover this behavior has to be consistent across all math functions, and probably cast functions as well. I just noticed, since we use rust math functions, it returns `NaN` values for outlier scenarios, and this going to be consistent, even not complying to how PG works ``` ❯ select sqrt(-1); +-----------------+ | sqrt(Int64(-1)) | +-----------------+ | NaN | +-----------------+ ``` whereas PG bursts as ``` cannot take square root of a negative number ``` I'll leave it for @alamb @andygrove to decide -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
