jorisvandenbossche commented on PR #14662: URL: https://github.com/apache/arrow/pull/14662#issuecomment-1433110164
@MarcoGorelli sorry for the slow follow-up here. I think this would be valuable to add yes (and otherwise we should certainly merge the clean-ups you found with this). Agreed with @raulcd that ideally this would be exposed through archery. The way this is done for flake8 is we wrap the command line: https://github.com/apache/arrow/blob/13335454729bcc3e2a3062f5ba7a8da7fc39751f/dev/archery/archery/lang/python.py#L34-L36 and then run that here: https://github.com/apache/arrow/blob/13335454729bcc3e2a3062f5ba7a8da7fc39751f/dev/archery/archery/utils/lint.py#L219-L235 Given that cython-lint also has a command line, I suppose that should be straightforward to add (but that can also be done as a follow-up). For the actual diff here, I only have some concern that the changes in the docstring (because of line length) might be messing up how it shows, so checking that with the doc build. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
