metesynnada commented on PR #5299: URL: https://github.com/apache/arrow-datafusion/pull/5299#issuecomment-1433236978
> > LGTM. Have you resolved the `thread::sleep` issue related to the `CoalescePartitionsExec` usage? The test does not seem to suggest that. > > Not sure what "the `thread::sleep` issue" is, but the sleep is not required to trigger the bug. If you perform a `thread::sleep` in tokio, you for sure block the entire executor thread during the sleep. This is expected behavior. You should never do that (expect when you use [`spawn_blocking`](https://docs.rs/tokio/latest/tokio/task/fn.spawn_blocking.html), but that comes w/ I a performance penalty). > > The test blocks forever without the yield point, so IMHO this fixes the original issue. I see. Thanks for the contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
