paleolimbot commented on code in PR #463:
URL: https://github.com/apache/arrow-adbc/pull/463#discussion_r1108907641
##########
c/driver/sqlite/utils.h:
##########
@@ -48,36 +48,35 @@ void StringBuilderAppend(struct StringBuilder* builder,
const char* value);
void StringBuilderReset(struct StringBuilder* builder);
/// Check an NanoArrow status code.
-#define CHECK_NA(CODE, EXPR, ERROR)
\
- do {
\
- ArrowErrorCode arrow_error_code = (EXPR);
\
- if (arrow_error_code != 0) {
\
- SetError(ERROR, "%s failed: (%d) %s\nDetail: %s:%d %s", #EXPR,
arrow_error_code, \
- strerror(arrow_error_code), __FILE__, __LINE__, __FUNCTION__);
\
- return ADBC_STATUS_##CODE;
\
- }
\
+#define CHECK_NA(CODE, EXPR, ERROR)
\
+ do {
\
+ ArrowErrorCode arrow_error_code = (EXPR);
\
+ if (arrow_error_code != 0) {
\
+ SetError(ERROR, "%s failed: (%d) %s\nDetail: %s:%d", #EXPR,
arrow_error_code, \
+ strerror(arrow_error_code), __FILE__, __LINE__);
\
+ return ADBC_STATUS_##CODE;
\
Review Comment:
These changes are because of:
```
* checking whether package 'adbcsqlite' can be installed ... WARNING
Found the following significant warnings:
sqlite.c:152:45: warning: format '%ld' expects argument of type 'long
int', but argument 3 has type 'size_t' {aka 'long long unsigned int'}
[-Wformat=]
utils.h:56:64: warning: ISO C does not support '__FUNCTION__' predefined
identifier [-Wpedantic]
utils.h:68:36: warning: ISO C does not support '__FUNCTION__' predefined
identifier [-Wpedantic]
utils.h:78:26: warning: ISO C does not support '__FUNCTION__' predefined
identifier [-Wpedantic]
```
I could also define an alternative set of `CHECK_*` functions but it seems
like file + line will give enough context in this case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
