felipecrv commented on code in PR #33641: URL: https://github.com/apache/arrow/pull/33641#discussion_r1109139081
########## cpp/src/arrow/util/ree_util.h: ########## @@ -0,0 +1,351 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#pragma once + +#include <algorithm> +#include <cassert> +#include <cstdint> + +#include "arrow/array/data.h" +#include "arrow/type_traits.h" +#include "arrow/util/macros.h" + +namespace arrow { +namespace ree_util { + +/// \brief Get the child array holding the run ends from an REE array +inline const ArraySpan& RunEndsArray(const ArraySpan& span) { return span.child_data[0]; } + +/// \brief Get the child array holding the data values from an REE array +inline const ArraySpan& ValuesArray(const ArraySpan& span) { return span.child_data[1]; } + +/// \brief Get a pointer to run ends values of an REE array +template <typename RunEndsType> +const RunEndsType* RunEnds(const ArraySpan& span) { + assert(RunEndsArray(span).type->id() == CTypeTraits<RunEndsType>::ArrowType::type_id); + return RunEndsArray(span).GetValues<RunEndsType>(1); +} + +namespace internal { + +/// \brief Uses binary-search to find the physical offset given a logical offset +/// and run-end values +/// +/// \return the physical offset or run_ends_size if the physical offset is not +/// found in run_ends +template <typename RunEndsType> +int64_t FindPhysicalIndex(const RunEndsType* run_ends, int64_t run_ends_size, int64_t i, + int64_t absolute_offset) { + auto it = std::upper_bound(run_ends, run_ends + run_ends_size, absolute_offset + i); + int64_t result = std::distance(run_ends, it); + assert(result <= run_ends_size); + return result; +} + +/// \brief Uses binary-search to calculate the number of physical values (and +/// run-ends) necessary to represent the logical range of values from +/// offset to length +template <typename RunEndsType> +int64_t FindPhysicalLength(int64_t length, int64_t offset, const RunEndsType* run_ends, + int64_t run_ends_size) { Review Comment: I agree. I will fix this now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
