westonpace commented on code in PR #34208:
URL: https://github.com/apache/arrow/pull/34208#discussion_r1109171816
##########
docs/source/cpp/compute.rst:
##########
@@ -1445,6 +1445,8 @@ For timestamps inputs with non-empty timezone, localized
timestamp components wi
+--------------------+------------+-------------------+---------------+----------------------------+-------+
| is_leap_year | Unary | Timestamp, Date | Boolean |
| |
+--------------------+------------+-------------------+---------------+----------------------------+-------+
+| local_time | Unary | Timestamp | Timestamp |
| |
Review Comment:
Can we add a note? I don't think it will be obvious what this function does.
##########
cpp/src/arrow/compute/api_scalar.h:
##########
@@ -1518,6 +1518,16 @@ ARROW_EXPORT Result<Datum> AssumeTimezone(const Datum&
values,
ARROW_EXPORT Result<Datum> IsDaylightSavings(const Datum& values,
ExecContext* ctx = NULLPTR);
+/// \brief LocalTime converts timestamp to timezone naive local timestamp
+///
+/// \param[in] values input to convert to local time
+/// \param[in] ctx the function execution context, optional
+/// \return the resulting datum
+///
+/// \since 12.0.0
+/// \note API not yet finalized
Review Comment:
I was going to suggest removing this but now I see this is everywhere.
Hmm.... :( I'm not sure how true this is these days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
