alamb opened a new pull request #8687: URL: https://github.com/apache/arrow/pull/8687
We do currently run clippy (aka rust linter) on all PRs. However, the way we invoke clippy means that any clippy warnings introduced in PRs do not cause a CI failure I believe the intended behavior is that we keep the arrow project "Clippy clean" For example, this PR (doesn't introduce the warning), but clippy flags a warning and yet the test still apsses: https://github.com/apache/arrow/runs/1408182529?check_suite_focus=true {code} Checking arrow v3.0.0-SNAPSHOT (/Users/runner/work/arrow/arrow/rust/arrow) warning: unneeded unit return type --> arrow/src/buffer.rs:694:45 | 694 | pub fn resize(&mut self, new_len: usize) -> () { | ^^^^^^ help: remove the `-> ()` | = note: `#[warn(clippy::unused_unit)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit warning: 1 warning emitted Finished dev [unoptimized + debuginfo] target(s) in 1m 11s ~/work/arrow/arrow {code} Testing of this PR: * The initial commit of this PR f50ca5a only includes the updated clippy command and it fails CI (see XXX) * When the second commit to fix the clippy warning is introduced, then CI passes ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
