jaylmiller commented on issue #5230:
URL: 
https://github.com/apache/arrow-datafusion/issues/5230#issuecomment-1435788637

   Also, I just realized that the sort benchmark is kindof bad (my mistake 😬) 
because when `preserve_partitioning` is false, it expects input with a single 
partition, which it was not giving--it was 8 separate partitions, so 
effectively it was only running on a fraction of the input data, and was only 
representing a specific case where it sorts each batch separately (this case is 
still represented in the 'preserve partitioning' cases btw).
   
   I've added this fix in PR #5308.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to