jaylmiller commented on code in PR #5308:
URL: https://github.com/apache/arrow-datafusion/pull/5308#discussion_r1111122943
##########
datafusion/core/benches/sort.rs:
##########
@@ -199,7 +200,8 @@ impl SortBenchCase {
let projection = None;
let exec = MemoryExec::try_new(partitions, schema,
projection).unwrap();
- let plan = Arc::new(SortExec::try_new(sort, Arc::new(exec),
None).unwrap());
+ let exec = Arc::new(CoalescePartitionsExec::new(Arc::new(exec)));
+ let plan = Arc::new(SortExec::try_new(sort, exec, None).unwrap());
Review Comment:
without this change it was only ever benchmarking the case where the
`execute` receives a single record batch to sort.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
