adamreeve commented on PR #34181: URL: https://github.com/apache/arrow/pull/34181#issuecomment-1436089135
Thanks for the feedback @wjones127, I've addressed all of these points except for the one about using overloads as I think it might be more important to have overloads on the `CryptoFactory` methods instead. I'm not sure how important ABI stability is though, should anything not in an internal namespace use overloads when adding parameters to avoid breaking ABI compatibility? I've also updated the parquet-testing submodule now that https://github.com/apache/parquet-testing/pull/36 is merged, so all tests should pass :crossed_fingers: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
