thisisnic commented on PR #34050: URL: https://github.com/apache/arrow/pull/34050#issuecomment-1436815827
I figured a sensible approach to this PR is to write a test for the desired behaviour, and then implement something to make the test pass. I noticed other tests in a similar region of code seem to use this "Arrow -> serialize to Substrait -> deserialize to Arrow -> check things match" pattern. However, on further inspection, it doesn't seem like a lot of 'Arrow -> Substrait' serialization is implemented. Am I better off just manually specifying the plan using `SubstraitFromJSON()`, and testing I get the desired Arrow behaviour? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
