tustvold commented on code in PR #3736:
URL: https://github.com/apache/arrow-rs/pull/3736#discussion_r1111845813
##########
arrow-json/src/raw/tape.rs:
##########
@@ -87,14 +92,15 @@ impl Display for TapeElement {
///
/// [simdjson]: https://github.com/simdjson/simdjson/blob/master/doc/tape.md
#[derive(Debug)]
-pub struct Tape<'a> {
+pub struct Tape<'a, C: TapeConverter> {
Review Comment:
I think it would make for a cleaner interface if the converter were instead
given the tape instead of `Tape` being parameterised on `TapeConverter`. This
would allow `ArrayDecoder` and by extension `RawDecoder` / `RawReader` to not
need a generic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
