jorisvandenbossche commented on PR #34208: URL: https://github.com/apache/arrow/pull/34208#issuecomment-1436959754
Nice to see this functionality! One comment on the name of the function: given that "local_time" could also be interpreted as returning just the time (a `time32/64()` type) and not both date and time (and theoretically, this could also be a kernel we would want to add at some point), we could maybe use `"local_timestamp"` instead? (I know that some will day that "local timestamp" is a contradictio in terminis, and that it should be "local datetime" instead, but since we don't use "datetime" for any other kernel name and "timestamp" is the name of the type anyway, that seems the best option). For reference, in Joda they call this `toLocalDateTime` (and they also have a `toLocalDate` and `toLocalTime`), in pandas the naming is confusing (`tz_localize(None)`), and in R's lubridate there is a `local_time` that does _somewhat_ related, except that it returns the difference in seconds instead of new timestamp object. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
