tustvold commented on code in PR #3734:
URL: https://github.com/apache/arrow-rs/pull/3734#discussion_r1112006379
##########
arrow-csv/src/reader/mod.rs:
##########
@@ -866,21 +866,24 @@ fn parse_decimal_with_parameter<T: DecimalType>(
let mut negative = false;
let mut result = T::Native::usize_as(0);
- for byte in bytes[0..offset].iter().rev() {
- match byte {
+ bytes[0..offset]
+ .iter()
+ .rev()
+ .try_for_each::<_, Result<(), ArrowError>>(|&byte| match byte {
b'-' => {
negative = true;
+ Ok(())
Review Comment:
It might be cleaner to lift the `Ok(())` out of the match, but don't feel
strongly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
