jackwener commented on PR #5335:
URL: 
https://github.com/apache/arrow-datafusion/pull/5335#issuecomment-1438438771

   > but I think we should have some sort of test that passes with this change 
and fails without it. The rationale being that without such coverage this logic 
may get lost during a refactoring or some other code change and we wouldn't 
know because no test would fail
   
   Thank you @alamb , I add a new integration-test for this issue.
   Before this PR, it will fail. it will work after this PR.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to