alamb commented on PR #5322: URL: https://github.com/apache/arrow-datafusion/pull/5322#issuecomment-1438468030
> It may be possible to do this if we carve out things like interval arithmetic, constraint propagation etc. into separate PRs. However, that will deprive you of important context (i.e. where/how do we use these things and why do they have the APIs that they have). For this reason, I suggest keeping this in one piece, and following a top-down order to make reviewing easier (and in parts): I agree it is a tradeoff. Your suggestion of reviewing as one PR sounds good. > I agree, it comes down to personal work style. Let's play by ear and see if my suggestions above help. If not, we can always try breaking it up. Our goal is to make the review process be efficient/easy, after all 🙂 Yes, thank you! I am just trying to offer suggestions to help get your PRs in faster in the future. (I am reading the blog post this morning so hopefully will be ready to review more in depth the next few days) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
