tustvold commented on issue #3742: URL: https://github.com/apache/arrow-rs/issues/3742#issuecomment-1438690111
Same as commented on the CSV writer ticket, https://github.com/apache/arrow-rs/issues/3740#issuecomment-1438682974, I would recommend implementing this by buffering an encoded batch in memory using the existing writer, prior to flushing it via async. This avoids code duplication, is more generic, and is likely significantly faster. It has been my experience that async does not optimise very well, especially in tight loops, and is best kept independent of the hot synchronous code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
