jorisvandenbossche commented on code in PR #34263:
URL: https://github.com/apache/arrow/pull/34263#discussion_r1113545506
##########
cpp/src/arrow/compute/kernels/scalar_temporal_unary.cc:
##########
@@ -1807,11 +1807,12 @@ const FunctionDoc is_dst_doc{
"An error is returned if the values do not have a defined timezone."),
{"values"}};
-const FunctionDoc local_time_doc{
+const FunctionDoc local_timestamp_doc{
"Convert timestamp to a timezone-naive local time timestamp",
- ("LocalTime converts a timestamp to a local time of timestamps timezone\n"
- "and removes timezone metadata. If input is in UTC or doesn't have\n"
- "timezone metadata, it is returned as is.\n"
+ ("LocalTimestamp converts timezone-aware timestamp to local timestamp\n"
+ "of the given timestamps timezone and removes timezone metadata.\n"
Review Comment:
"timestamps timezone" -> should that be "timestamp's timezone" ? (otherwise
I don't fully understand the sentence)
Maybe we can also include "wall clock time" somewhere in the explanation?
##########
cpp/src/arrow/compute/api_scalar.cc:
##########
@@ -834,7 +834,7 @@ SCALAR_EAGER_UNARY(DayOfYear, "day_of_year")
SCALAR_EAGER_UNARY(Hour, "hour")
SCALAR_EAGER_UNARY(YearMonthDay, "year_month_day")
SCALAR_EAGER_UNARY(IsDaylightSavings, "is_dst")
-SCALAR_EAGER_UNARY(LocalTime, "local_time")
+SCALAR_EAGER_UNARY(LocalTime, "local_timestamp")
Review Comment:
Also rename LocalTime ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
