wjones127 commented on PR #34181: URL: https://github.com/apache/arrow/pull/34181#issuecomment-1439163077
> Thanks for the feedback @wjones127, I've addressed all of these points except for the one about using overloads as I think it might be more important to have overloads on the CryptoFactory methods instead. I'm not sure how important ABI stability is though, should anything not in an internal namespace use overloads when adding parameters to avoid breaking ABI compatibility? We don't aim for ABI stability as much as maintaining usability right now. But we do try to maintain a sort of API stability for C++ code when we can, including adding deprecation messages to functions that will be removed in future versions. I think overloads seem appropriate for the methods that take _either_ `KeyMaterialStore` or file path + `FileSystem`. It seems weird to have one function that expects only one of either parameters to be passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
