westonpace commented on code in PR #34137:
URL: https://github.com/apache/arrow/pull/34137#discussion_r1113713497
##########
cpp/src/arrow/compute/exec/exec_plan.h:
##########
@@ -146,6 +148,46 @@ class ARROW_EXPORT ExecNode {
virtual Status Validate() const;
+ /// \brief the ordering of the output batches
+ ///
+ /// This does not guarantee the batches will be emitted by this node
+ /// in order. Instead it guarantees that the batches will have their
+ /// ExecBatch::index property set in a way that respects this ordering.
+ ///
+ /// In other words, given the ordering {{"x", SortOrder::Ascending}} we
+ /// know that all values of x in a batch with index N will be less than
+ /// or equal to all values of x in a batch with index N+k (assuming k > 0)
Review Comment:
I've updated the wording here to mention ordering within a batch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
