wgtmac commented on PR #34193: URL: https://github.com/apache/arrow/pull/34193#issuecomment-1439697272
> The skeleton LGTM. I wonder that if ther is a corner case: > > ``` > rep-levels 1, 1, 0 > batch = 3 > ``` > > And we found last record is `0`, but the last record should not be flushed? In your case, the batch will call action twice: - levels: 1, 1, w/ page size check - levels: 0, w/o page size check -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
