fatemehp commented on code in PR #17877:
URL: https://github.com/apache/arrow/pull/17877#discussion_r1114727560
##########
cpp/src/parquet/column_reader.h:
##########
@@ -364,10 +373,15 @@ class PARQUET_EXPORT RecordReader {
}
/// \brief Decoded values, including nulls, if any
+ /// FLBA and ByteArray types do not use this array and read into their own
+ /// builders.
uint8_t* values() const { return values_->mutable_data(); }
- /// \brief Number of values written including nulls (if any)
- /// There is no read-ahead/buffering for values.
+ /// \brief Number of values written, including space left for nulls if any.
+ /// If this Reader was constructed with read_dense_for_nullable(), there is
no space for
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]