tustvold opened a new pull request, #3749:
URL: https://github.com/apache/arrow-rs/pull/3749
_Draft as builds on #3743_
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Part of #1799
Relates to #1176
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
This starts the process of fleshing out what the elements of the `ArrayData`
enumeration will consist of, with implementations for primitive and byte
arrays. I wanted to get something up for review to get feedback on the general
direction, and to also avoid a single massive PR.
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
This PR adds enumerations `ArrayDataPrimitive` and `ArrayDataBytes`, that
consist of the enumerable variants of the generic `PrimitiveArrayData` and
`BytesArrayData`.
These provide for an idiomatic way to enumerate the possible array types,
with the view that this would eventually replace the current trait object
approach.
Additionally `downcast` / `downcast_ref` / `From` are provided to facilitate
going from the enumeration to/from the generic form. This is critical to
allowing types such as `PrimitiveArray` to be contain `PrimitiveArrayData`
whilst being constructable from an `ArrayData` enumeration containing
`ArrayDataPrimitive`.
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking
change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
