lidavidm commented on code in PR #34227: URL: https://github.com/apache/arrow/pull/34227#discussion_r1114948622
########## java/dataset/src/main/java/org/apache/arrow/dataset/substrait/SubstraitConsumer.java: ########## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.arrow.dataset.substrait; + +import org.apache.arrow.c.ArrowArrayStream; +import org.apache.arrow.c.Data; +import org.apache.arrow.memory.BufferAllocator; +import org.apache.arrow.vector.ipc.ArrowReader; + +/** + * Java binding of the C++ ExecuteSerializedPlan. + */ +public class SubstraitConsumer implements AutoCloseable { Review Comment: Seems like this should be an interface? ########## java/dataset/src/main/java/org/apache/arrow/dataset/substrait/SubstraitConsumer.java: ########## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.arrow.dataset.substrait; + +import org.apache.arrow.c.ArrowArrayStream; +import org.apache.arrow.c.Data; +import org.apache.arrow.memory.BufferAllocator; +import org.apache.arrow.vector.ipc.ArrowReader; + +/** + * Java binding of the C++ ExecuteSerializedPlan. + */ +public class SubstraitConsumer implements AutoCloseable { + private final BufferAllocator allocator; + + public SubstraitConsumer(BufferAllocator allocator) { + this.allocator = allocator; + } + + /** + * Execute Substrait Plan to read Schema and ArrowRecordBatches. + * + * @param substraitPlan the JSON Substrait plan. + * @return the ArrowReader to iterate for record batches. + */ + public ArrowReader runQuery(String substraitPlan) { Review Comment: Plans should be byte[] or ByteBuffer? ########## ci/scripts/java_jni_manylinux_build.sh: ########## @@ -45,6 +45,7 @@ export ARROW_ORC : ${ARROW_PLASMA:=ON} export ARROW_PLASMA : ${ARROW_S3:=ON} +: ${ARROW_SUBSTRAIT:=ON} Review Comment: This has to always match ARROW_DATASET so a separate variable won't make sense ########## java/dataset/src/main/java/org/apache/arrow/dataset/substrait/SubstraitConsumer.java: ########## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.arrow.dataset.substrait; + +import org.apache.arrow.c.ArrowArrayStream; +import org.apache.arrow.c.Data; +import org.apache.arrow.memory.BufferAllocator; +import org.apache.arrow.vector.ipc.ArrowReader; + +/** + * Java binding of the C++ ExecuteSerializedPlan. + */ +public class SubstraitConsumer implements AutoCloseable { + private final BufferAllocator allocator; + + public SubstraitConsumer(BufferAllocator allocator) { + this.allocator = allocator; + } + + /** + * Execute Substrait Plan to read Schema and ArrowRecordBatches. + * + * @param substraitPlan the JSON Substrait plan. + * @return the ArrowReader to iterate for record batches. + */ + public ArrowReader runQuery(String substraitPlan) { Review Comment: It seems this assumes JSON plans which is probably not what people will be working with -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
