mingmwang commented on PR #5290: URL: https://github.com/apache/arrow-datafusion/pull/5290#issuecomment-1441256555
@mustafasrepo @ozankabak After a closer look at the test comparing result, I think the differences mainly relate to preserve ordering(`maintains_input_order`). I had highlighted the two test cases. From my point of view, the rules should not remove those Sorts, the rules should respect the `maintains_input_order()` and decide what sorts can be removed or not, even sometimes those Sort are better than necessary. And In the TopDown rule implementation, I can add another configuration flag to enable removing Sorts more aggressively and achieve the same results as the the Bottom-up rule, but we still need to define clearly in which cases Sort can be removed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
