lidavidm commented on code in PR #15129:
URL: https://github.com/apache/arrow/pull/15129#discussion_r1115656198
##########
cpp/src/arrow/util/utf8.h:
##########
@@ -31,7 +31,7 @@ namespace util {
// Convert a UTF8 string to a wstring (either UTF16 or UTF32, depending
// on the wchar_t width).
-ARROW_EXPORT Result<std::wstring> UTF8ToWideString(const std::string& source);
+ARROW_EXPORT Result<std::wstring> UTF8ToWideString(const std::string_view&
source);
Review Comment:
nit: pass string_view by value?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
