ozankabak commented on PR #5322: URL: https://github.com/apache/arrow-datafusion/pull/5322#issuecomment-1441990911
Thank you @alamb! We will resolve the merge conflict, do a final pass addressing the reviews, and will let you know when it is good to go from our perspective. > The biggest risk of this PR, in my opinion is the accumulated technical debt of a third range analysis library and another join implementation that is not widely used (in my mind SortMergeJoin also falls in this cateogry). However, I am confident given past interactions the synnadai team will help us unify the approaches and so I think we can merge this PR in as is (and file some follow on tickets) Sounds good! We will close the loop on all these in the upcoming weeks. We already started some of this work (interval library extension and subsequently unification) > Another thing that worries me, but is not introduced by this PR, is the size of `datafusion-core` (it would be amazing to break out all the physical_plan stuff to a new module) but that is also well beyond the scope of this PR This sounds good to me too. We will need to do this at some point, physical plan code is getting quite big. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
