westonpace commented on issue #34310:
URL: https://github.com/apache/arrow/issues/34310#issuecomment-1442285990

   > I get errors and segfaults.
   
   This should not segfault, even if given an invalid plan.  Are you possibly 
calling ValueOrDie in R when running a plan?  If not, this bears investigation 
on its own.
   
   > If I specify the output type in the binding, I get a segfault:
   
   It is not obvious, but the only [valid 
kernels](https://github.com/substrait-io/substrait/blob/main/extensions/functions_rounding.yaml)
 for round are:
   
   ```
   round(i8, i32)
   round(i16, i32)
   round(i32, i32)
   round(i64, i32)
   found(fp32, i32)
   round(fp64, i32)
   ```
   In other words, the `s` argument (how many digits) MUST be `int32`.  It 
appears that you are passing in `float`.
   
   > If I remove the line which specifies the output type, I instead get the 
error:
   
   The output type must always be specified.  An error is correct behavior here.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to