rtpsw commented on code in PR #34311:
URL: https://github.com/apache/arrow/pull/34311#discussion_r1116173036
##########
cpp/src/arrow/compute/exec/aggregate_node.cc:
##########
@@ -570,8 +773,12 @@ class GroupByNode : public ExecNode, public TracedNode {
return output_->InputReceived(this, out_data_.Slice(batch_size * n,
batch_size));
}
- Status OutputResult() {
- auto scope = TraceFinish();
+ Status OutputResult(bool is_last = false, bool traced = false) {
Review Comment:
`is_last` is `true` when this is the last time `OutputResult` is called in
this node. In this case, when `traced` is also `true`, the invocation is traced
using the facilities inherited from `TracedNode`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
