[GitHub] [arrow] Ulimo commented on a change in pull request #8694: ARROW-10542: [C#][Flight] Add beginning on flight code for net core

[GitBox]

Ulimo commented on a change in pull request #8694:
URL: https://github.com/apache/arrow/pull/8694#discussion_r525574841



##########
File path: 
csharp/test/Apache.Arrow.Flight.TestWeb/Apache.Arrow.Flight.TestWeb.csproj
##########
@@ -0,0 +1,16 @@
+<Project Sdk="Microsoft.NET.Sdk.Web">
+
+  <PropertyGroup>
+    <TargetFramework>netcoreapp3.0</TargetFramework>
+  </PropertyGroup>
+
+  <ItemGroup>
+    <PackageReference Include="Grpc" Version="2.33.1" />

Review comment:
       This is just for the tests where I use some of the extension methods, 
such as ToListAsync() etc, Is it considered bad practice to use it even in 
those cases?
   
   Edit: my bad, sorry, removing it




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org