kou opened a new pull request, #34325:
URL: https://github.com/apache/arrow/pull/34325
### Rationale for this change
`std::set(iterator, iterator)` doesn't work with old g++ on Ubuntu 18.04:
FAILED:
src/arrow/util/CMakeFiles/arrow-utility-test.dir/rows_to_batches_test.cc.o
c++ ... -std=c++1z ... -c
/arrow/cpp/src/arrow/util/rows_to_batches_test.cc
/arrow/cpp/src/arrow/util/rows_to_batches_test.cc: In lambda function:
/arrow/cpp/src/arrow/util/rows_to_batches_test.cc:85:61: error: class
template argument deduction failed:
return std::set(std::begin(s.values), std::end(s.values));
^
/arrow/cpp/src/arrow/util/rows_to_batches_test.cc:85:61: error: no
matching function for call to 'set(std::vector<int>::const_iterator,
std::vector<int>::const_iterator)'
In file included from /usr/include/c++/7/set:61:0,
from
googletest_ep-prefix/include/gtest/internal/gtest-internal.h:60,
from googletest_ep-prefix/include/gtest/gtest.h:62,
from
/arrow/cpp/src/arrow/util/rows_to_batches_test.cc:20:
/usr/include/c++/7/bits/stl_set.h:261:2: note: candidate: template<class
_Key, class _Compare, class _Alloc, class _InputIterator> set(_InputIterator,
_InputIterator, const _Alloc&)-> std::set<_Key, _Compare, _Alloc>
set(_InputIterator __first, _InputIterator __last,
^~~
/usr/include/c++/7/bits/stl_set.h:261:2: note: template argument
deduction/substitution failed:
/arrow/cpp/src/arrow/util/rows_to_batches_test.cc:85:61: note:
candidate expects 3 arguments, 2 provided
return std::set(std::begin(s.values), std::end(s.values));
^
In file included from /usr/include/c++/7/set:61:0,
from
googletest_ep-prefix/include/gtest/internal/gtest-internal.h:60,
from googletest_ep-prefix/include/gtest/gtest.h:62,
from
/arrow/cpp/src/arrow/util/rows_to_batches_test.cc:20:
/usr/include/c++/7/bits/stl_set.h:255:7: note: candidate: template<class
_Key, class _Compare, class _Alloc> set(std::initializer_list<_Tp>, const
allocator_type&)-> std::set<_Key, _Compare, _Alloc>
set(initializer_list<value_type> __l, const allocator_type& __a)
^~~
...
### What changes are included in this PR?
Specify type explicitly.
### Are these changes tested?
Yes.
### Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
