Ted-Jiang commented on code in PR #683:
URL: https://github.com/apache/arrow-ballista/pull/683#discussion_r1116643620
##########
ballista/core/src/execution_plans/shuffle_writer.rs:
##########
@@ -219,10 +219,7 @@ impl ShuffleWriterExec {
partitioner.partition(
input_batch,
|output_partition, output_batch| {
- // write non-empty batch out
-
- // TODO optimize so we don't write or fetch
empty partitions
- // if output_batch.num_rows() > 0 {
+ // partition func in datafusion make sure not
write empty output_batch.
Review Comment:
related code
https://github.com/apache/arrow-datafusion/blob/ded897ee7f4944ab5ef266854e000179650b5f07/datafusion/core/src/physical_plan/repartition/mod.rs#L194-L196
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
