thisisnic commented on code in PR #34050:
URL: https://github.com/apache/arrow/pull/34050#discussion_r1116740631
##########
cpp/src/arrow/engine/substrait/serde_test.cc:
##########
@@ -774,6 +774,127 @@ TEST(Substrait, CallExtensionFunction) {
}
}
+TEST(Substrait, CallCast) {
+ ExtensionSet ext_set;
+ ConversionOptions conversion_options;
+
+ ASSERT_OK_AND_ASSIGN(auto buf,
+ internal::SubstraitFromJSON("Expression", R"({
+ "selection": {
+ "directReference": {
+ "structField": {
Review Comment:
I am also surprised, didn't even know it could be supplied both ways - must
have copied and pasted multiple bits from elsewhere. Fixed now!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
