liyafan82 commented on pull request #8605: URL: https://github.com/apache/arrow/pull/8605#issuecomment-729338224
> @liyafan82 seems working correctly in all cases if we add `writer.startList` and `writer.endList` together with `vector.setNull`. > I have refactored `writeListVector` function in test to make it more universal. > > May be we should add a getter for `protected FixedSizeListVector vector` prorerty in `UnionFixedSizeListWriter` and/or cache `FixedSizeListVector.getWriter` output (in current version new writer is created on every invocation). This allows `writeListVector` ans similar methods to have only vector or only writer parameter with keeping new functional. > > Cross-test with C++ is again made in [my project](https://github.com/Kopilov/Arrow_FixedSizeListVector_ZeroWidth/runs/1403388868). But where are cross tests made in Apache Arrow itself? @Kopilov Thanks for your effort. It looks reasonable. Will merge soon if there are no more comments. Concerning the problem of caching writers, maybe you can open a separate JIRA for it, if you think it necessary. We have integeration tests across different languages in "Integration / AMD64 Conda Integration Test (pull_request)" when a PR is submitted. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
