jorgecarleitao commented on a change in pull request #8700:
URL: https://github.com/apache/arrow/pull/8700#discussion_r525849824
##########
File path: rust/arrow/src/compute/kernels/boolean.rs
##########
@@ -159,53 +159,113 @@ mod tests {
let a = BooleanArray::from(vec![false, false, true, true]);
let b = BooleanArray::from(vec![false, true, false, true]);
let c = and(&a, &b).unwrap();
- assert_eq!(false, c.value(0));
- assert_eq!(false, c.value(1));
- assert_eq!(false, c.value(2));
- assert_eq!(true, c.value(3));
+
+ let expected = BooleanArray::from(vec![false, false, false, true]);
+
+ assert_eq!(c, expected);
}
#[test]
fn test_bool_array_or() {
let a = BooleanArray::from(vec![false, false, true, true]);
let b = BooleanArray::from(vec![false, true, false, true]);
let c = or(&a, &b).unwrap();
- assert_eq!(false, c.value(0));
- assert_eq!(true, c.value(1));
- assert_eq!(true, c.value(2));
- assert_eq!(true, c.value(3));
+
+ let expected = BooleanArray::from(vec![false, true, true, true]);
+
+ assert_eq!(c, expected);
}
#[test]
fn test_bool_array_or_nulls() {
- let a = BooleanArray::from(vec![None, Some(false), None, Some(false)]);
- let b = BooleanArray::from(vec![None, None, Some(false), Some(false)]);
+ let a = BooleanArray::from(vec![
+ None,
+ None,
+ None,
+ Some(false),
+ Some(false),
+ Some(false),
+ Some(true),
+ Some(true),
+ Some(true),
+ ]);
+ let b = BooleanArray::from(vec![
+ None,
+ Some(false),
+ Some(true),
+ None,
+ Some(false),
+ Some(true),
+ None,
+ Some(false),
+ Some(true),
+ ]);
let c = or(&a, &b).unwrap();
- assert_eq!(true, c.is_null(0));
- assert_eq!(true, c.is_null(1));
- assert_eq!(true, c.is_null(2));
- assert_eq!(false, c.is_null(3));
+
+ let expected = BooleanArray::from(vec![
+ None,
+ None,
+ None,
+ None,
+ Some(false),
+ Some(true),
+ None,
+ Some(true),
+ Some(true),
+ ]);
+
+ assert_eq!(c, expected);
}
#[test]
fn test_bool_array_not() {
- let a = BooleanArray::from(vec![false, false, true, true]);
+ let a = BooleanArray::from(vec![false, true]);
let c = not(&a).unwrap();
- assert_eq!(true, c.value(0));
- assert_eq!(true, c.value(1));
- assert_eq!(false, c.value(2));
- assert_eq!(false, c.value(3));
+
+ let expected = BooleanArray::from(vec![true, false]);
+
+ assert_eq!(c, expected);
}
#[test]
fn test_bool_array_and_nulls() {
Review comment:
test expanded to cover all possible cases.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
