GregBowyer commented on pull request #8698: URL: https://github.com/apache/arrow/pull/8698#issuecomment-729478929
I think I pulled all the transmutes out so thats good > Thanks @GregBowyer for the PR. It's will be awesome if we can get this done. I think before merging this we should get some benchmark results showing the diff before & after. We use to have [some benchmark in the old repo](https://github.com/sunchao/parquet-rs/tree/master/benches) but haven't port them to arrow yet. I will just pull them in tomorrow and get some baselines, I dont think it will be that hard. I _doubt_ there will be anything here for performance. I mean there are some more branches now, but I suspect the predict effortlessly, and on the flip side we are not chasing things around the I-Cache so I suspect its a wash in the end. However better checked than assumed. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
